[Intel-gfx] [RFC 1/2] drm/i915/uc: Move uC related types into dedicated header

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed Sep 27 09:51:24 UTC 2017


On Tue, 2017-09-26 at 16:48 +0000, Michal Wajdeczko wrote:
> In old header structure we were mixing type definitions and
> declarations that prevent us from exposing some functions
> as inline. Lets try to fix that.
> 
> Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>

This is a nice improvement. I see Sagar already provided detailed
review, so please address that (it's always good idea to reduce the
amount of forward declarations). Overall, this is:

Acked-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list