[Intel-gfx] [PATCH] drm/i915: Add has_psr-flag to gen9lp

[David Weinehall]

On Tue, Aug 08, 2017 at 12:50:51PM -0700, Rodrigo Vivi wrote:
> a long time ago I had agreed with Daniel that we would only add new
> platforms after it was enabled by default on previous platforms.
> a big reason for that is that we was willing to reduce the platforms
> to validate and do better validation one by one before enabling.
> 
> However now I believe it would be beneficial to have that supported
> added so we can get more brave people using in different platforms so
> we could capture more corner cases before we enable it by default.
> Also we can still enable by default one platform at time if needed.
> 
> So:
> 
> Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> I also checked the spec to see if there was anything else new or
> different for these platforms and didn't find anything so:
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> But let's wait a bit to merge to give Daniel or others a time to nack ;)

An update: while testing revealed that our BXT-P RVP doesn't work with
PSR, the GLK definitely does. CI would like to do PSR testing on GLK,
which obviously isn't possible if PSR is reported as unsupported on GLK.

Based on BSpec alone the PSR failure on BXT-P shouldn't be a
Broxton/Apollo Lake issue, but rather an issue with the RVP board
(or the panel), so I'd say that this patch still makes sense.

After all it only changes gen9lp to report that they *can* support PSR
(thus allowing for testing of PSR on such platforms), it doesn't enable
it by default.

So I'd like to nudge once more that this patch be merged.

Daniel, any objections?


Kind regards, David Weinehall