[Intel-gfx] [PATCH 2/3] dim: auto-add remotes

[Rodrigo Vivi]

On Wed, Sep 27, 2017 at 09:48:49AM +0000, Daniel Vetter wrote:
> Well, bother to at least prompt. Prep work for adding drm-amd.git.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
>  dim | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/dim b/dim
> index 4d75c7a7fb0e..6ebbad2b6dfd 100755
> --- a/dim
> +++ b/dim
> @@ -274,7 +274,14 @@ function url_to_remote # url
>  			echoerr "Please set it up using:"
>  			echoerr "    $ git remote add <name> $url"

I think these 2 messages above doesn't make sense anymore, right?

>  			echoerr "with a name of your choice."
> -			return 1

\o/
I like to see more automation on the setup...

> +			remote=${url%.git}
> +			remote=${remote##*/}
> +			read -r -i "$remote" -e -p "Enter a name to auto-add this remote, leave blank to abort: " || true

I'd be more in favor of forcing a standard and be flexible on .dimrc to any later change if people
really need that.

Anyways not blocking.
With messages above checked:

Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> +			if [[ "$REPLY" == "" ]] ; then
> +				exit 1
> +			fi
> +
> +			git remote add $remote $url
>  		fi
>  	fi
>  
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx