[Intel-gfx] [PATCH v10 3/9] drm/i915: Create uC runtime and system suspend/resume helpers

[Chris Wilson]

Quoting Sagar Arun Kamble (2017-09-27 10:30:33)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 174a7c5..f79646b 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1698,6 +1698,16 @@ static int i915_drm_resume(struct drm_device *dev)
>         }
>         mutex_unlock(&dev->struct_mutex);
>  
> +       /*
> +        * NB: Currently we know that at the end of suspend we have done Full
> +        * GPU reset, Hence GuC is loaded again during i915_gem_init_hw.
> +        * Now, send action to GuC to resume back again as earlier call to
> +        * intel_uc_resume from i915_gem_resume would have done nothing.
> +        */

When you say "GuC is loaded again during i915_gem_init_hw" are you
thinking of the i915_reset call or i915_drm_resume call? We are using
intel_gpu_reset() to do the full device reset at suspend/resume, so
bypassing the i915_gem_init_hw from i915_reset. Could you clarify what
you mean by "hence"?
-Chris