[Intel-gfx] [PATCH igt] igt/gem_exec_schedule: Detect too slow setup in deep-*

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 29 09:03:24 UTC 2017


Quoting Joonas Lahtinen (2017-09-29 09:48:42)
> On Thu, 2017-09-28 at 12:20 +0100, Chris Wilson wrote:
> > Using vgem as our cork for building the request queue limits us to 10s
> > of setup (or else the fence autoexpires and we start executing too
> > early). Add timeouts to the setup loops and SKIP if we cannot establish
> > the workload within 10s, the machine and driver is too slow to evaluate
> > the expected results.
> > 
> > To avoid the artificial limit of 10s requires lifting the dependency on
> > vgem and switching to sw_sync and explicit fencing. Just a matter of
> > plumbing!
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> <SNIP>
> 
> > @@ -483,21 +485,48 @@ static void deep(int fd, unsigned ring)
> >       for (int m = 0; m < XS; m ++)
> >               dep[m] = gem_create(fd, size);
> >  
> > +     /* Bind the surfaces into each of the contexts */
> 
> "before starting timeout measurement."

Too long, can you get rid of about 20 characters?

I took it as read that you could see that it was before starting the
timeout.
-Chris


More information about the Intel-gfx mailing list