[Intel-gfx] [PATCH v2 2/2] drm/i915: Make intel_guc_wopcm_size() inline

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Sep 29 09:12:01 UTC 2017


On Wed, 2017-09-27 at 11:22 +0000, Michal Wajdeczko wrote:
> While here fix param and var types to match new naming rules.
> 
> v2: update names and commit message (Sagar)
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>

Generally, when the function ends up being used only from single .c
file, you may drop the intel_ prefix and just have it as a private
inline.

So in intel_uc.c as "guc_wopcm_size".

We should try to have the related code in same files and avoid having
functions in the .h files to the extent we can. For example here this
is very much an implementation detail.

When moved there with the rename, this is;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list