[Intel-gfx] [PATCH i-g-t] igt_command_line.sh: Fix bashism

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Sep 29 09:34:48 UTC 2017


On Tue, 2017-09-26 at 14:01 +0200, Daniel Vetter wrote:
> On Mon, Sep 25, 2017 at 02:48:41PM +0300, Jani Nikula wrote:
> > On Mon, 25 Sep 2017, Petri Latvala <petri.latvala at intel.com> wrote:
> > > [[ a != b ]] is a bashism. As it's just comparing $1 to an empty
> > > string, use -n with a normal [ ].
> > > 
> > > /bin/sh is dash in CI.
> > 
> > There's probably /bin/bash around anyway, but I'm tired of fighting the
> > fight. So never mind about that.
> 
> Yeah, let's just switch to /bin/bash and stop bothering with dash. At
> least I don't see any value in trying to be posix compliant, we're not
> going to run on anything that doesn't have bash anyway.

I'm actively running I-G-T with busybox sh, so please cut with the
/bin/bash stuff, it's not that hard to be POSIX compliant.

Original patch is;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list