[Intel-gfx] [PATCH] drm/i915/selftests: Replace wmb() with i915_gem_chipset_flush()

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 29 10:29:47 UTC 2017


Quoting Joonas Lahtinen (2017-09-29 10:31:22)
> On Tue, 2017-09-26 at 16:34 +0100, Chris Wilson wrote:
> > Currently, we are being fairly lazy and only using a wmb() following an
> > update to an active batch. Previously, we have found that to be
> > insufficient to ensure that a write from the CPU reaches memory in a
> > timely fashion, and in some caches we may need to flush a chipset cache.
> > To that end, we have i915_gem_chipset_flush() so use it.
> > 
> > Suggested-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> 
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Thanks for the review, queued for pushing.
-Chris


More information about the Intel-gfx mailing list