[Intel-gfx] [PATCH 5/9] drm/i915: Move core GuC functions into dedicated file

Sagar Arun Kamble sagar.a.kamble at intel.com
Sat Sep 30 17:06:19 UTC 2017



On 9/29/2017 11:11 PM, Michal Wajdeczko wrote:
> We want to keep GuC functions together. While here move
> send registers initialization to early init as this is
> one time operation.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
<snip>
> +void intel_guc_init_early(struct intel_guc *guc)
> +{
> +	intel_guc_ct_init_early(&guc->ct);
> +
> +	mutex_init(&guc->send_mutex);
> +	guc->send = intel_guc_send_nop;
> +	guc->notify = gen8_guc_raise_irq;
> +	guc_init_send_regs(guc);
Better to address guc_init_send_regs move in new patch as discussed.
Otherwise overall patch looks good to me.



More information about the Intel-gfx mailing list