[Intel-gfx] [PATCH v7 2/8] drm/i915: Add CRTC output format YCBCR 4:2:0

Dan Carpenter dan.carpenter at oracle.com
Wed Apr 4 08:49:28 UTC 2018


Hi Shashank,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20180403]
[cannot apply to v4.16]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Shashank-Sharma/YCBCR-4-2-0-4-4-4-output-support-for-LSPCON/20180403-181234
base:   git://anongit.freedesktop.org/drm-intel for-linux-next

New smatch warnings:
drivers/gpu/drm/i915/intel_display.c:10678 output_formats() error: buffer overflow 'output_format_str' 3 <= 3

# https://github.com/0day-ci/linux/commit/51bf28f3f43755c090f4ae3519868bef7b20bf75
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 51bf28f3f43755c090f4ae3519868bef7b20bf75
vim +/output_format_str +10678 drivers/gpu/drm/i915/intel_display.c

ffc57acc Shashank Sharma 2018-04-03  10672  
ffc57acc Shashank Sharma 2018-04-03  10673  static const char *output_formats(enum intel_output_format format)
ffc57acc Shashank Sharma 2018-04-03  10674  {
51bf28f3 Shashank Sharma 2018-04-03  10675  	if (format < INTEL_OUTPUT_FORMAT_RGB ||
51bf28f3 Shashank Sharma 2018-04-03  10676  	    format > ARRAY_SIZE(output_format_str))
ffc57acc Shashank Sharma 2018-04-03  10677  		format = INTEL_OUTPUT_FORMAT_INVALID;
ffc57acc Shashank Sharma 2018-04-03 @10678  	return output_format_str[format];
ffc57acc Shashank Sharma 2018-04-03  10679  }
ffc57acc Shashank Sharma 2018-04-03  10680  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


More information about the Intel-gfx mailing list