[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: link config compute refactoring

Patchwork patchwork at emeril.freedesktop.org
Thu Apr 5 14:49:03 UTC 2018


== Series Details ==

Series: drm/i915/dp: link config compute refactoring
URL   : https://patchwork.freedesktop.org/series/41215/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
19ed1ef3a8e0 drm/i915/dp: remove stale comment about bw constants
462b0f09da14 drm/i915/dp: move link_bw and rate_select debugging where used
91ccfa6a90e0 drm/i915/dp: abstract dp link config computation from the rest
-:159: WARNING:LINE_SPACING: Missing a blank line after declarations
#159: FILE: drivers/gpu/drm/i915/intel_dp.c:1834:
+			int ret;
+			ret = skl_update_scaler_crtc(pipe_config);

total: 0 errors, 1 warnings, 0 checks, 207 lines checked
a41f8820d9e6 drm/i915/dp: move eDP VBT bpp claming code to intel_dp_compute_bpp()
-:32: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#32: FILE: drivers/gpu/drm/i915/intel_dp.c:1674:
+		if (intel_connector->base.display_info.bpc == 0 &&
+			(dev_priv->vbt.edp.bpp && dev_priv->vbt.edp.bpp < bpp)) {

total: 0 errors, 0 warnings, 1 checks, 50 lines checked
ee8d5e24aa74 drm/i915/dp: group link config limits in a struct
-:68: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#68: FILE: drivers/gpu/drm/i915/intel_dp.c:1746:
+				limits.min_clock = limits.max_clock = index;

-:69: WARNING:LONG_LINE: line over 100 characters
#69: FILE: drivers/gpu/drm/i915/intel_dp.c:1747:
+			limits.min_lane_count = limits.max_lane_count = intel_dp->compliance.test_lane_count;

-:69: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#69: FILE: drivers/gpu/drm/i915/intel_dp.c:1747:
+			limits.min_lane_count = limits.max_lane_count = intel_dp->compliance.test_lane_count;

total: 0 errors, 1 warnings, 2 checks, 96 lines checked
046eaebcfc30 drm/i915/dp: abstract link config selection
d714852b2c0a drm/i915/dp: fix compliance test adjustments
-:46: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#46: FILE: drivers/gpu/drm/i915/intel_dp.c:1709:
+		limits->min_bpp = limits->max_bpp = bpp;

-:65: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#65: FILE: drivers/gpu/drm/i915/intel_dp.c:1728:
+				limits->min_clock = limits->max_clock = index;

-:66: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#66: FILE: drivers/gpu/drm/i915/intel_dp.c:1729:
+			limits->min_lane_count = limits->max_lane_count =

total: 0 errors, 0 warnings, 3 checks, 88 lines checked



More information about the Intel-gfx mailing list