[Intel-gfx] [PATCH v3] drm/i915: Split out parking from the idle worker for reuse

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 6 19:08:06 UTC 2018


Quoting Michal Wajdeczko (2018-04-06 17:57:20)
> On Fri, 06 Apr 2018 17:51:44 +0200, Chris Wilson  
> <chris at chris-wilson.co.uk> wrote:
> 
> > We will want to park GEM before disengaging the drive^W^W^W unwedging.
> > Since we already do the work for idling, expose the guts as a new
> > function that we can then reuse.
> >
> > v2: Just skip if already parked; makes it more forgiving to use by
> > future callers.
> > v3: Extract mark_busy, rename it to i915_gem_unpark and place it next to
> > i915_gem_park so that we can evaluate it for symmetry more easily.
> > Calling GEM from inside i915_request looks to be a bit of a layering
> > violation, for the moment I am imaging them as being notify_cb.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com> #v1
> > ---
> 
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

And into the mix it goes. Thanks for the suggestions and reviews,
-Chris


More information about the Intel-gfx mailing list