[Intel-gfx] [PATCH] drm/i915: Park before resetting the submission backend

Michal Wajdeczko michal.wajdeczko at intel.com
Mon Apr 9 10:49:43 UTC 2018


On Mon, 09 Apr 2018 12:41:22 +0200, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Sagar Arun Kamble (2018-04-09 11:38:34)
>>
>>
>> On 4/9/2018 3:48 PM, Chris Wilson wrote:
>> > As different backends may have different park/unpark callbacks, we
>> > should only ever switch backends (reset_default_submission on wedge
>> > recovery, or on enabling the guc) while parked.
>> >
>> > v2: Remove the assert from the guc code, as we are currently trying to
>> > modify the engine vfuncs pointer on a live system after reset (not  
>> just
>> > wedging). We will just have to hope that the system is balanced.
>> > v3: Rebase onto __i915_gem_park and improve grammar.
>> >
>> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> > Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
>> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
>
> Michal, do you want to take this and merge it into your series?

Yes, I can take it.
Then we will see results from CI.IGT with GuC enabled.

/Michal

ps. this patch is also

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>


More information about the Intel-gfx mailing list