[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file
URL   : https://patchwork.freedesktop.org/series/41486/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8044c5a3e8e3 drm/i915: Move a bunch of workaround-related code to its own file
-:742: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#742: 
new file mode 100644

-:791: ERROR:TRAILING_WHITESPACE: trailing whitespace
#791: FILE: drivers/gpu/drm/i915/intel_workarounds.c:45:
+ * $

-:816: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#816: FILE: drivers/gpu/drm/i915/intel_workarounds.c:70:
+#define WA_REG(addr, mask, val) do { \
+		const int r = wa_add(dev_priv, (addr), (mask), (val)); \
+		if (r) \
+			return r; \
+	} while (0)

-:822: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#822: FILE: drivers/gpu/drm/i915/intel_workarounds.c:76:
+#define WA_SET_BIT_MASKED(addr, mask) \
+	WA_REG(addr, (mask), _MASKED_BIT_ENABLE(mask))

-:825: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#825: FILE: drivers/gpu/drm/i915/intel_workarounds.c:79:
+#define WA_CLR_BIT_MASKED(addr, mask) \
+	WA_REG(addr, (mask), _MASKED_BIT_DISABLE(mask))

-:828: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#828: FILE: drivers/gpu/drm/i915/intel_workarounds.c:82:
+#define WA_SET_FIELD_MASKED(addr, mask, value) \
+	WA_REG(addr, mask, _MASKED_FIELD(mask, value))

-:955: WARNING:LONG_LINE: line over 100 characters
#955: FILE: drivers/gpu/drm/i915/intel_workarounds.c:209:
+	I915_WRITE(GEN9_CSFE_CHICKEN1_RCS, _MASKED_BIT_ENABLE(GEN9_PREEMPT_GPGPU_SYNC_SWITCH_DISABLE));

-:1246: ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#1246: FILE: drivers/gpu/drm/i915/intel_workarounds.c:500:
+	ret= wa_ring_whitelist_reg(engine, GEN8_CS_CHICKEN1);
 	   ^

-:1290: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1290: FILE: drivers/gpu/drm/i915/intel_workarounds.c:544:
+	WA_SET_BIT_MASKED(

-:1350: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1350: FILE: drivers/gpu/drm/i915/intel_workarounds.c:604:
+	WA_SET_BIT_MASKED(

-:1430: WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#1430: FILE: drivers/gpu/drm/i915/intel_workarounds.c:684:
+}

total: 2 errors, 4 warnings, 5 checks, 1381 lines checked
e9f5cebfbf56 drm/i915: Split out functions for different kinds of workarounds
-:409: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#409: FILE: drivers/gpu/drm/i915/intel_workarounds.c:364:
+	WA_SET_BIT_MASKED(

-:456: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#456: FILE: drivers/gpu/drm/i915/intel_workarounds.c:399:
+	WA_SET_BIT_MASKED(

-:512: CHECK:BRACES: braces {} should be used on all arms of this statement
#512: FILE: drivers/gpu/drm/i915/intel_workarounds.c:450:
+	if (INTEL_GEN(dev_priv) < 8)
[...]
+	else if (IS_BROADWELL(dev_priv))
[...]
+	else if (IS_CHERRYVIEW(dev_priv))
[...]
+	else if (IS_SKYLAKE(dev_priv))
[...]
+	else if (IS_BROXTON(dev_priv))
[...]
+	else if (IS_KABYLAKE(dev_priv))
[...]
+	else if (IS_GEMINILAKE(dev_priv))
[...]
+	else if (IS_COFFEELAKE(dev_priv))
[...]
+	else if (IS_CANNONLAKE(dev_priv))
[...]
+	else {
[...]

-:530: CHECK:BRACES: Unbalanced braces around else statement
#530: FILE: drivers/gpu/drm/i915/intel_workarounds.c:468:
+	else {

-:822: WARNING:LINE_SPACING: Missing a blank line after declarations
#822: FILE: drivers/gpu/drm/i915/intel_workarounds.c:744:
+	int ret = gen9_whitelist_workarounds_apply(engine);
+	if (ret)

-:851: WARNING:LINE_SPACING: Missing a blank line after declarations
#851: FILE: drivers/gpu/drm/i915/intel_workarounds.c:767:
+	int ret = gen9_whitelist_workarounds_apply(engine);
+	if (ret)

-:868: WARNING:LINE_SPACING: Missing a blank line after declarations
#868: FILE: drivers/gpu/drm/i915/intel_workarounds.c:781:
+	int ret = gen9_whitelist_workarounds_apply(engine);
+	if (ret)

-:889: WARNING:LINE_SPACING: Missing a blank line after declarations
#889: FILE: drivers/gpu/drm/i915/intel_workarounds.c:795:
+	int ret = gen9_whitelist_workarounds_apply(engine);
+	if (ret)

-:933: CHECK:BRACES: braces {} should be used on all arms of this statement
#933: FILE: drivers/gpu/drm/i915/intel_workarounds.c:822:
+	if (INTEL_GEN(dev_priv) < 8)
[...]
+	else if (IS_BROADWELL(dev_priv))
[...]
 	else if (IS_CHERRYVIEW(dev_priv))
[...]
+		err = chv_whitelist_workarounds_apply(engine);
[...]
-		err =  skl_init_workarounds(engine);
[...]
 	else if (IS_BROXTON(dev_priv))
[...]
+		err = bxt_whitelist_workarounds_apply(engine);
[...]
-		err = kbl_init_workarounds(engine);
[...]
 	else if (IS_GEMINILAKE(dev_priv))
[...]
+		err = glk_whitelist_workarounds_apply(engine);
[...]

-:959: CHECK:BRACES: Unbalanced braces around else statement
#959: FILE: drivers/gpu/drm/i915/intel_workarounds.c:840:
+	else {

total: 0 errors, 4 warnings, 6 checks, 905 lines checked