[Intel-gfx] [PATCH] drm/i915: Enforce read order into the hardware status page csb

Chris Wilson chris at chris-wilson.co.uk
Thu Apr 12 14:01:06 UTC 2018


Quoting Chris Wilson (2018-04-12 14:57:42)
> Quoting Mika Kuoppala (2018-04-12 14:52:37)
> > Read ordering on cpu can be out of order and speculative.
> 
> If it didn't include a barrier to prevent compiler mispeculation. rmb()
> only applies to other CPU cores and not the GPU so this is entirely
> hocus.

Or think of it in terms checkpatch will ask you, where is the
corresponding wmb()?
-Chris


More information about the Intel-gfx mailing list