[Intel-gfx] [PATCH] drm/i915: Refine the has_audio assignment

Shi, Yang A yang.a.shi at intel.com
Thu Apr 19 01:22:33 UTC 2018


>-----Original Message-----
>From: Jani Nikula [mailto:jani.nikula at linux.intel.com]
>Sent: Wednesday, April 18, 2018 8:44 PM
>To: Chris Wilson <chris at chris-wilson.co.uk>; Shi, Yang A <yang.a.shi at intel.com>;
>intel-gfx at lists.freedesktop.org
>Cc: Shi, Yang A <yang.a.shi at intel.com>
>Subject: Re: [Intel-gfx] [PATCH] drm/i915: Refine the has_audio assignment
>
>On Fri, 13 Apr 2018, Chris Wilson <chris at chris-wilson.co.uk> wrote:
>> Quoting Yang (2018-04-13 05:06:45)
>>> From: Yang Shi <yang.a.shi at intel.com>
>>>
>>> Refine the has_audio assignment for dp and hdmi.
>>
>> s/Refine/Ignore the user override for/
>>
>> Why?
>
>Yang, we'll need the explanation before we continue with review or even consider
>merging. We routinely ignore patches where questions go unanswered.
>
>BR,
>Jani.

This code change is just to make driver code more readable.
If(condition) value = a  else value = condition looks redundancy.

BR.
Yang.

>
>
>--
>Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list