[Intel-gfx] [PATCH 6/7] drm/i915: Split i915_gem_timeline into individual timelines

[Chris Wilson]

Quoting Tvrtko Ursulin (2018-04-27 15:37:58)
> 
> On 26/04/2018 18:49, Chris Wilson wrote:
> > -static bool engine_has_idle_kernel_context(struct intel_engine_cs *engine)
> > +static struct i915_request *
> > +last_timeline_request(struct i915_timeline *timeline,
> > +                   struct intel_engine_cs *engine)
> >   {
> > -     struct i915_gem_timeline *timeline;
> > +     struct i915_request *rq;
> >   
> > -     list_for_each_entry(timeline, &engine->i915->gt.timelines, link) {
> > -             struct intel_timeline *tl;
> > +     if (timeline == &engine->timeline)
> > +             return NULL;
> 
> You are skipping engine timelines here? Would it be clearer if the 
> caller did this in the list_for_each_entry loop?

Yeah, that we want to skip the engine->timeline isn't a property of
"last_timeline_request", but that of the caller.
-Chris