[Intel-gfx] [PATCH] drm/i915/execlists: Terminate the context image with BB_END

[Chris Wilson]

Quoting Lionel Landwerlin (2018-07-31 13:47:32)
> On 30/07/18 17:43, Chris Wilson wrote:
> > In the aub trace utility, the context images are terminated with a
> > MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
> > Do the same for our protocontext image for completeness, and in passing
> > apply the magic bit for gen10 to mark the end of the context image.
> >
> > Reported-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> 
> Doesn't look like anything exploded.
> Have you noticed any improvement maybe in the benchmarks?

In practice, it is replaced by HW state, so it only applies to the very
first context load on which it is meant to be suppressed. Interesting to
note that the HW only terminates RCS with a BB_END.
-Chris