[Intel-gfx] [PATCH 3/4] drm/i915: Clear all residual RPS events on disabling interrupts

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 3 14:13:00 UTC 2018


Quoting Mika Kuoppala (2018-08-03 14:59:58)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index e0f5999fff07..4b656f31fde9 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -8582,8 +8582,10 @@ enum {
> >  #define  GEN6_PM_RP_DOWN_THRESHOLD           (1 << 4)
> >  #define  GEN6_PM_RP_UP_EI_EXPIRED            (1 << 2)
> >  #define  GEN6_PM_RP_DOWN_EI_EXPIRED          (1 << 1)
> > -#define  GEN6_PM_RPS_EVENTS                  (GEN6_PM_RP_UP_THRESHOLD | \
> > -                                              GEN6_PM_RP_DOWN_THRESHOLD | \
> > +#define  GEN6_PM_RPS_EVENTS                  (GEN6_PM_RP_UP_EI_EXPIRED   | \
> > +                                              GEN6_PM_RP_UP_THRESHOLD    | \
> > +                                              GEN6_PM_RP_DOWN_EI_EXPIRED | \
> > +                                              GEN6_PM_RP_DOWN_THRESHOLD  | \
> >                                                GEN6_PM_RP_DOWN_TIMEOUT)
> 
> GEN6_PM_RPS_MASK ?

I think we are still missing a few, so events as a superset of
pm_rps_events seems like a reasonable minimum change :)

Bonus, add the ones we are missing.
-Chris


More information about the Intel-gfx mailing list