[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Clean up power well descriptors (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Aug 6 10:09:32 UTC 2018


== Series Details ==

Series: drm/i915: Clean up power well descriptors (rev2)
URL   : https://patchwork.freedesktop.org/series/46952/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6c5eac3775d7 drm/i915/icl: Fix power well anonymous union initializers
69d41b65c165 drm/i915: Rename intel_power_domains_fini() to intel_power_domains_fini_hw()
26c9786d1d90 drm/i915/vlv: Remove redundant power well ID asserts
91d740c8b8c3 drm/i915: Constify power well descriptors
-:548: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#548: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:2821:
+	power_domains->power_wells = kcalloc(power_well_count,
+					    sizeof(*power_domains->power_wells),

-:570: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well_descs' - possible side-effects?
#570: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:2839:
+#define set_power_wells(power_domains, __power_well_descs) \
+	__set_power_wells(power_domains, __power_well_descs, \
+			  ARRAY_SIZE(__power_well_descs))

total: 0 errors, 0 warnings, 2 checks, 643 lines checked
b9b4129e0c4b drm/i915/vlv: Use power well CTL IDX instead of ID
63bb461d5477 drm/i915/ddi: Use power well CTL IDX instead of ID
-:270: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#270: FILE: drivers/gpu/drm/i915/i915_reg.h:9034:
+#define CNL_AUX_ANAOVRD1(pw_idx)	_MMIO(_PICK(_CNL_AUX_REG_IDX(pw_idx), \
 						    _CNL_AUX_ANAOVRD1_B, \
 						    _CNL_AUX_ANAOVRD1_C, \
 						    _CNL_AUX_ANAOVRD1_D, \

total: 1 errors, 0 warnings, 0 checks, 970 lines checked
084bb4517662 drm/i915: Remove redundant power well IDs
7dbcf6a6c869 drm/i915: Make power well ID names more uniform
140918e2ab61 drm/i915: Use existing power well IDs where possible
6fc28e2d1537 drm/i915/icl: Add missing power gate enums



More information about the Intel-gfx mailing list