[Intel-gfx] [PATCH v3] drm/i915/tracing: Enable user interrupts while intel_engine_notify is active

[Tvrtko Ursulin]

On 09/08/2018 10:22, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-08-09 10:07:51)
>> diff --git a/drivers/gpu/drm/i915/i915_tracing.h b/drivers/gpu/drm/i915/i915_tracing.h
>> new file mode 100644
>> index 000000000000..4d8710f5687b
>> --- /dev/null
>> +++ b/drivers/gpu/drm/i915/i915_tracing.h
>> @@ -0,0 +1,29 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright © 2018 Intel Corporation
>> + *
>> + */
>> +#ifndef _I915_TRACING_H_
>> +#define _I915_TRACING_H_
>> +
>> +#if IS_ENABLED(CONFIG_TRACEPOINTS)
>> +
>> +#include "i915_drv.h"
> 
> Nit here. You can just have a struct drm_i915_private; forward decl,
> that you need for both paths.

Yes thanks, I'll do that.

I also need to add some comments to i915_tracing.c since it still looks 
rather like a prototype.

Regards,

Tvrtko


>> +
>> +void i915_tracing_register(struct drm_i915_private *i915);
>> +void i915_tracing_unregister(struct drm_i915_private *i915);
>> +
>> +int intel_engine_notify_tracepoint_register(void);
>> +void intel_engine_notify_tracepoint_unregister(void);
>> +
>> +#else
>> +
>> +static inline void i915_tracing_register(struct drm_i915_private *i915) { }
>> +static inline void i915_tracing_unregister(struct drm_i915_private *i915) { }
>> +
>> +static inline int intel_engine_notify_tracepoint_register(void) { }
>> +static inline void intel_engine_notify_tracepoint_unregister(void) { }
>> +
>> +#endif
>> +
>> +#endif
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>