[Intel-gfx] [PATCH] drm/i915/selftests: Hold rpm for unparking

Chris Wilson chris at chris-wilson.co.uk
Thu Aug 9 10:45:10 UTC 2018


Quoting Mika Kuoppala (2018-08-09 11:40:35)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > The call to i915_gem_unpark() checks that we hold a rpm wakeref before
> > taking a long term wakeref for i915->gt.awake. We should therefore make
> > sure we do hold the wakeref when directly calling unpark to disable
> > the retire worker.
> 
> We as a caller need to hold the rpm as i915_gem_unpark does 
> intel_runtime_pm_get_noresume() ?

Correct. noresume says that the caller must have down the synchronous
rpm_get for us.
-Chris


More information about the Intel-gfx mailing list