[Intel-gfx] [PATCH] drm/i915: Bump priority of clean up work

Chris Wilson chris at chris-wilson.co.uk
Mon Aug 13 13:00:27 UTC 2018


Quoting Mika Kuoppala (2018-08-13 13:49:43)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Quoting Chris Wilson (2018-07-12 12:57:29)
> >> We require that we keep the list of outstanding work short so that we do
> >> not "leak" memory while pageflipping under stress. However that system
> >> stress may delay kernel workers virtually indefinitely, which incurs the
> >> pageflips stall and eventually hit a timeout waiting for the cleanup.
> >> 
> >> Try to combat CPU starvation of our short-lived cleanup workers by
> >> switching to a high priority workqueue.
> >> 
> >> Testcase: igt/kms_cursor_legacy/all-pipes-torture-move
> >> References: https://bugs.freedesktop.org/show_bug.cgi?id=107122
> >> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> >> ---
> >> Not sure if highpri is enough to combat our RT torture...
> >
> > CI thinks it is.
> 
> Not so familiar with the atomic commit. But it makes
> sense and now there is evidence supporting it.

Proof is indeed in the pudding; the CI stress case is about the worst it
can be so, with any luck the starvation issue is prevented. Thanks,
pushed.
-Chris


More information about the Intel-gfx mailing list