[Intel-gfx] [PATCH 02/14] drm/i915: Restrict gen6_reset_rps_interrupts to gen6+

Mika Kuoppala mika.kuoppala at linux.intel.com
Mon Aug 13 16:09:06 UTC 2018


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Do not call gen6_reset_rps_interrupts() when we know the registers do not
> exist.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

This makes me wonder about adding some known gen6+ debug
register range assertions to I915_WRITE when gen < 6.

i915.mmio_debug for all (gens) :)

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 03654f5f68c3..9a01560c5bd1 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8260,7 +8260,7 @@ void intel_sanitize_gt_powersave(struct drm_i915_private *dev_priv)
>  
>  	if (INTEL_GEN(dev_priv) >= 11)
>  		gen11_reset_rps_interrupts(dev_priv);
> -	else
> +	else if (INTEL_GEN(dev_priv) >= 6)
>  		gen6_reset_rps_interrupts(dev_priv);
>  }
>  
> -- 
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list