[Intel-gfx] [PATCH] drm/i915: Verify power domains after enabling them

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 17 12:32:24 UTC 2018


Quoting Imre Deak (2018-08-17 13:26:13)
> After
> commit 2cd9a689e97b ("Refactor intel_display_set_init_power() logic")
> it makes more sense to check the power domain/well refcounts after
> enabling the power domains functionality. Before that it's guaranteed
> that most power wells (in the INIT domain) will have a reference held,
> so not an interesting state.

Indeed, that is true. But it is also used to check that we do acquire
the powerwells on init. I think it would sensible to include a verify
state at the end of power_domains_init_hw, or do you think the
sync_hw makes that superfluous?
-Chris


More information about the Intel-gfx mailing list