[Intel-gfx] [PATCH v2] drm/i915: Verify power domains after enabling them

[Chris Wilson]

Quoting Imre Deak (2018-08-17 14:18:02)
> After
> commit 2cd9a689e97b ("Refactor intel_display_set_init_power() logic")
> it makes more sense to check the power domain/well refcounts after
> enabling the power domains functionality. Before that it's guaranteed
> that most power wells (in the INIT domain) will have a reference held,
> so not an interesting state.
> 
> While at it also add the check after the init_hw/fini_hw, disable
> and suspend/resume steps. The check is fast since the power well HW
> state is cached.
> 
> v2:
> - Add the state check to more spots. (Chris)
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
> @@ -3865,6 +3875,10 @@ void intel_power_domains_suspend(struct drm_i915_private *dev_priv,
>                 bxt_display_core_uninit(dev_priv);
>  
>         power_domains->display_core_suspended = true;
> +
> +verify_state:
> +       intel_power_domains_verify_state(dev_priv);
> +
>  }

Bonus '\n'.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris