[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm: drm/i915: Add connector property to limit max bpc

Patchwork patchwork at emeril.freedesktop.org
Sat Aug 25 01:09:35 UTC 2018


== Series Details ==

Series: series starting with [v3,1/2] drm: drm/i915: Add connector property to limit max bpc
URL   : https://patchwork.freedesktop.org/series/48695/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
cf2501ba38fa drm: drm/i915: Add connector property to limit max bpc
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
connector property to make sure that bpc does not exceed the configured value.

-:125: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#125: FILE: drivers/gpu/drm/i915/intel_modes.c:146:
+	if (prop == NULL) {

-:127: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#127: FILE: drivers/gpu/drm/i915/intel_modes.c:148:
+		if (prop == NULL)

total: 0 errors, 1 warnings, 2 checks, 102 lines checked
7855b6acf894 drm/i915: Allow "max bpc" property to limit pipe_bpp
-:30: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#30: FILE: drivers/gpu/drm/i915/intel_display.c:10789:
+connected_sink_max_bpp(struct drm_connector_state *conn_state,
+			     struct intel_crtc_state *pipe_config)

-:35: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#35: FILE: drivers/gpu/drm/i915/intel_display.c:10794:
+		pipe_config->pipe_bpp = 8*3;
 		                         ^

-:39: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#39: FILE: drivers/gpu/drm/i915/intel_display.c:10798:
+		pipe_config->pipe_bpp = 10*3;
 		                          ^

-:42: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#42: FILE: drivers/gpu/drm/i915/intel_display.c:10801:
+		pipe_config->pipe_bpp = 12*3;
 		                          ^

total: 0 errors, 0 warnings, 4 checks, 37 lines checked



More information about the Intel-gfx mailing list