[Intel-gfx] [PATCH] drm/i915: Don't check power domains state in intel_power_domains_init_hw()

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 28 11:45:31 UTC 2018


Quoting Imre Deak (2018-08-28 12:40:43)
> During power domains initialization we acquire power well references for
> power wells in the INIT power domain. The rest of power wells - which
> BIOS could have left enabled - we can only acquire references as needed
> during display HW readout. Thus during initialization these latter power
> wells can have a refcount of 0 while still being enabled. To avoid the
> false-positive state mismatch error this causes remove the check from
> intel_power_domains_init_hw() and rely on the state check in
> intel_power_domains_enable() which follows the HW readout.

Missing from above is a quick explanation of how those extraneous
powerwells are sanitizied. If we don't do the HW readout
(i915.disable_display?) do we not then leave the powerwell active and so
complain in a later verify_state()?
-Chris


More information about the Intel-gfx mailing list