[Intel-gfx] [PATCH] drm/i915/selftests: ring all doorbells in igt_guc_doorbells

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 28 12:47:11 UTC 2018


Quoting Katarzyna Dec (2018-08-28 13:34:16)
> On Mon, Aug 27, 2018 at 03:36:14PM -0700, Daniele Ceraolo Spurio wrote:
> > We currently verify that all doorbells can be registerd with GuC and
> > HW but don't check that all works as expected after a db ring.
> > 
> > Do a nop ring of all doorbells to make sure we haven't misprogrammed
> > any WQ or stage descriptor data. This will also help validating
> > upcoming changes in the db programming flow.
> > 
> > Cc: Michel Thierry <michel.thierry at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
[snip]
> Selftests are new topic for me, but this one looks fairly simple. I hope
> I understand it correctly.
> Acked-by: Katarzyna Dec <katarzyna.dec at intel.com>

Fixed up the spelling mistake and pushed. Thanks for the review and more
testing,
-Chris


More information about the Intel-gfx mailing list