[Intel-gfx] [PATCH 2/2] drm/i915: Reject compressed Y/Yf with interlaced modes

Souza, Jose jose.souza at intel.com
Tue Aug 28 16:39:21 UTC 2018


On Tue, 2018-08-28 at 17:27 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Y/Yf tiling can't be used with IF-ID. We already reject uncompressed
> Y/Yf but we should also reject them when compressed.
> 

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> Cc: José Roberto de Souza <jose.souza at intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_atomic_plane.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c
> b/drivers/gpu/drm/i915/intel_atomic_plane.c
> index eddcdd6e4b3b..fa7df5fe154b 100644
> --- a/drivers/gpu/drm/i915/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/intel_atomic_plane.c
> @@ -170,7 +170,9 @@ int intel_plane_atomic_check_with_state(const
> struct intel_crtc_state *old_crtc_
>  	if (state->fb && INTEL_GEN(dev_priv) >= 9 && crtc_state-
> >base.enable &&
>  	    adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) {
>  		if (state->fb->modifier == I915_FORMAT_MOD_Y_TILED ||
> -		    state->fb->modifier == I915_FORMAT_MOD_Yf_TILED) {
> +		    state->fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
> +		    state->fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS
> ||
> +		    state->fb->modifier ==
> I915_FORMAT_MOD_Yf_TILED_CCS) {
>  			DRM_DEBUG_KMS("Y/Yf tiling not supported in IF-
> ID mode\n");
>  			return -EINVAL;
>  		}


More information about the Intel-gfx mailing list