[Intel-gfx] [PATCH] drm/i915: clear error registers after error capture

[Lionel Landwerlin]

On 30/08/2018 11:55, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-08-30 11:52:28)
>> We need to clear the register in order to get correct value after the
>> next potential hang.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_gpu_error.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index afd70deae7ef..1cc9cde41328 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -1768,6 +1768,8 @@ static int capture(void *data)
>>   
>>          error->epoch = capture_find_epoch(error);
>>   
>> +       i915_check_and_clear_faults(error->i915);
> We already have i915_clear_error_registers() high up in the caller. I'd
> like to pull i915_check_and_clear_faults() into
> i915_clear_error_registers, and so also clear the error regs on take
> over like we do for faults.
> -Chris
>
Thanks, sure.


-

Lionel