[Intel-gfx] [PATCH] i915/dp/fec: Fix static check warning

Chris Wilson chris at chris-wilson.co.uk
Sat Dec 1 18:56:35 UTC 2018


Quoting Anusha (2018-11-30 23:14:28)
> From: Anusha Srivatsa <anusha.srivatsa at intel.com>
> 
> Fix indentation error in the commit:
> commit 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")
> 
> Fixes: 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 38a6e82153fd..8fa28342cfe3 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4032,8 +4032,8 @@ static void intel_dp_get_dsc_sink_cap(struct intel_dp *intel_dp)
>                                               &intel_dp->fec_capable) < 0)
>                                 DRM_ERROR("Failed to read FEC DPCD register\n");
>  
> -               DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
> -                             intel_dp->fec_capable);
> +                       DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
> +                                     intel_dp->fec_capable);

I suggested it was useful to know !FEC CAPABILITY. If you are going to
print debug info, might as well show it all.
https://patchwork.freedesktop.org/patch/263060/
-Chris


More information about the Intel-gfx mailing list