[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Restore workarounds after engine reset and unify their handling (rev4)

Patchwork patchwork at emeril.freedesktop.org
Mon Dec 3 13:05:10 UTC 2018


== Series Details ==

Series: Restore workarounds after engine reset and unify their handling (rev4)
URL   : https://patchwork.freedesktop.org/series/53313/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2c7ee2141088 drm/i915: Record GT workarounds in a list
-:135: WARNING:ALLOC_WITH_MULTIPLY: Prefer kmalloc_array over kmalloc with multiply
#135: FILE: drivers/gpu/drm/i915/intel_workarounds.c:602:
+		list = kmalloc(ALIGN(wal->count + 1, grow) * sizeof(*wa),
+			       GFP_KERNEL);

-:148: CHECK:LINE_SPACING: Please don't use multiple blank lines
#148: FILE: drivers/gpu/drm/i915/intel_workarounds.c:615:
+
+

-:502: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#502: FILE: drivers/gpu/drm/i915/intel_workarounds.c:916:
+	wa_masked_en(wal,
+		    _3D_CHICKEN3,

total: 0 errors, 1 warnings, 2 checks, 726 lines checked
a814929884ca drm/i915: Introduce per-engine workarounds
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 59b449d5c82a ("drm/i915: Split out functions for different kinds of workarounds")'
#10: 
59b449d5c82a ("drm/i915: Split out functions for different kinds of

total: 1 errors, 0 warnings, 0 checks, 389 lines checked
21f44a8d57a8 drm/i915: Verify GT workaround state after GPU init
5e2506a706bf drm/i915/selftests: Add tests for GT and engine workaround verification
-:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

-:64: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#64: FILE: drivers/gpu/drm/i915/selftests/igt_reset.c:1:
+/*

-:114: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#114: FILE: drivers/gpu/drm/i915/selftests/igt_reset.h:1:
+/*

total: 0 errors, 3 warnings, 0 checks, 363 lines checked
5118aae39798 drm/i915: Move register white-listing to the common workaround framework
dea19ac0666f drm/i915: Fuse per-context workaround handling with the common framework
-:186: WARNING:ALLOC_WITH_MULTIPLY: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: drivers/gpu/drm/i915/intel_workarounds.c:77:
+		list = kmalloc(ALIGN(wal->count + 1, grow) * sizeof(*wa),
+			       GFP_KERNEL);

total: 0 errors, 1 warnings, 0 checks, 682 lines checked
b6aae830b133 drm/i915: Trim unused workaround list entries



More information about the Intel-gfx mailing list