[Intel-gfx] [PATCH 1/8] drm/i915/breadcrumbs: Reduce missed-breadcrumb false positive rate

[Tvrtko Ursulin]

On 03/12/2018 11:36, Chris Wilson wrote:
> Change the on-cpu check to on-runqueue to catch if the waiter has been
> woken (and reset its current_state back to TASK_UNINTERRUPTIBLE to
> perform the seqno check) but is sleeping due to being preempted off the
> cpu.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_breadcrumbs.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> index 84bf8d827136..447c5256f63a 100644
> --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c
> +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> @@ -27,11 +27,7 @@
>   
>   #include "i915_drv.h"
>   
> -#ifdef CONFIG_SMP
> -#define task_asleep(tsk) ((tsk)->state & TASK_NORMAL && !(tsk)->on_cpu)
> -#else
> -#define task_asleep(tsk) ((tsk)->state & TASK_NORMAL)
> -#endif
> +#define task_asleep(tsk) ((tsk)->state & TASK_NORMAL && !(tsk)->on_rq)
>   
>   static unsigned int __intel_breadcrumbs_wakeup(struct intel_breadcrumbs *b)
>   {
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko