[Intel-gfx] [PATCH v11 00/23] drm/i915/icl: dsi enabling

Tue Dec 4 16:26:11 UTC 2018

Hi,

Currently ICL DSI panel seems to work fine, however I still face mainly two issues,
which probably need to be addressed:

1) There is still pipe_config mismatch assertion:

[   13.119965] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_hdisplay (expected 1440, found 720)
[   13.119989] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_htotal (expected 1586, found 793)
[   13.120015] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_hblank_start (expected 1440, found 1)
[   13.120038] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_hblank_end (expected 1586, found 1)
[   13.120061] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_hsync_start (expected 1540, found 770)
[   13.120083] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_hsync_end (expected 1550, found 775)
[   13.120113] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_vblank_start (expected 2560, found 1)
[   13.120139] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_vblank_end (expected 2582, found 1)
[   13.120169] [drm:pipe_config_err [i915]] *ERROR* mismatch in output_format (expected 0, found 1)
[   13.120188] [drm:pipe_config_err [i915]] *ERROR* mismatch in pixel_rate (expected 245700, found 122850)
[   13.120207] [drm:pipe_config_err [i915]] *ERROR* mismatch in pipe_bpp (expected 24, found 0)
[   13.120225] [drm:pipe_config_err [i915]] *ERROR* mismatch in base.adjusted_mode.crtc_clock (expected 245700, found 122850)

Also whenever I run some suspend test case(for example I use  igt at kms_vblank@pipe-a-ts-continuation-suspend
I start to get it everytime machine wakes up, DSI panel get blank and doesn't recover from that.

2) During reboot, there are sometimes flood of "The master control interrupt lied (DE PIPE)!" messages visible.
Looks like GEN8_DE_PIPE_IIR(pipe) which reads as 0 toggles this. Looks like also if I add a few retries it reads
correctly.

Could this be also because I'm still using old BIOS, which I've got initially from Vandita?

Best Regards,

Lisovskiy Stanislav

Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

________________________________________
From: Chauhan, Madhav
Sent: Tuesday, December 04, 2018 9:40 AM
To: Nikula, Jani; intel-gfx at lists.freedesktop.org
Cc: ville.syrjala at linux.intel.com; Kulkarni, Vandita; Lisovskiy, Stanislav; Deak, Imre
Subject: RE: [PATCH v11 00/23] drm/i915/icl: dsi enabling

> -----Original Message-----
> From: Nikula, Jani
> Sent: Monday, December 3, 2018 7:39 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: ville.syrjala at linux.intel.com; Chauhan, Madhav
> <madhav.chauhan at intel.com>; Kulkarni, Vandita
> <vandita.kulkarni at intel.com>; Lisovskiy, Stanislav
> <stanislav.lisovskiy at intel.com>; Deak, Imre <imre.deak at intel.com>
> Subject: Re: [PATCH v11 00/23] drm/i915/icl: dsi enabling
>
> On Thu, 29 Nov 2018, Jani Nikula <jani.nikula at intel.com> wrote:
> > v11 of [1], incorporating DSI PLL work [2] from Vandita as well as PLL
> > mapping and gating patches [3] from me and [4] from Imre.
> >
> > It made sense to squash some patches in [1] and [2] together, I've
> > tried to set authorship and co-developed-by tags fairly.
> >
> > The series is also available in icl-dsi-2018-11-29 branch of my fdo
> > git repo [5].
>
> Pushed the series to dinq except for the three HACK patches at the end.
> They'll still need to be addressed one way or another.
>
> Thanks everyone for your contributions in writing the patches, reviewing,
> testing, etc. It's been a long ride!

Thanks a lot to you as well Jani N for your continuous support during design/development/review/merge
Of this new/big feature :)

Regards,
Madhav

>
> BR,
> Jani.
>
>
>
> >
> >
> > BR,
> > Jani.
> >
> >
> > [1] https://patchwork.freedesktop.org/series/51011/
> > [2] https://patchwork.freedesktop.org/series/51373/
> > [3]
> > http://patchwork.freedesktop.org/patch/msgid/20181129115715.9152-1-
> jan
> > i.nikula at intel.com [4]
> > http://patchwork.freedesktop.org/patch/msgid/20181127163606.28841-1-
> im
> > re.deak at intel.com [5] https://cgit.freedesktop.org/~jani/drm/
> >
> >
> > Imre Deak (1):
> >   drm/i915/icl: Sanitize DDI port clock gating for DSI ports
> >
> > Jani Nikula (4):
> >   drm/i915/icl: push pll to port mapping/unmapping to ddi encoder hooks
> >   drm/i915/icl: add dummy DSI GPIO element execution function
> >   drm/i915/icl: add pll mapping for DSI
> >   HACK: drm/i915/bios: ignore VBT not overflowing the mailbox
> >
> > Madhav Chauhan (16):
> >   drm/i915/icl: Calculate DPLL params for DSI
> >   drm/i915/icl: Allocate DSI encoder/connector
> >   drm/i915/icl: Fill DSI ports info
> >   drm/i915/icl: Allocate DSI hosts and imlement host transfer
> >   drm/i915/icl: Get HW state for DSI encoder
> >   drm/i915/icl: Add DSI encoder compute config hook
> >   drm/i915/icl: Configure DSI Dual link mode
> >   drm/i915/icl: Consider DSI for getting transcoder state
> >   drm/i915/icl: Get pipe timings for DSI
> >   drm/i915/icl: Define missing bitfield for shortplug reg
> >   drm/i915/icl: Define Panel power ctrl register
> >   drm/i915/icl: Define display GPIO pins for DSI
> >   drm/i915/icl: Gate clocks for DSI
> >   drm/i915/icl: Ungate DSI clocks
> >   HACK: drm/i915/icl: Add changes to program DSI panel GPIOs
> >   HACK: drm/i915/icl: Configure backlight functions for DSI
> >
> > Vandita Kulkarni (2):
> >   drm/i915/icl: Use the same pll functions for dsi
> >   drm/i915/icl: Add get config functionality for DSI
> >
> >  drivers/gpu/drm/i915/i915_reg.h       |  12 +
> >  drivers/gpu/drm/i915/icl_dsi.c        | 492
> +++++++++++++++++++++++++++++++++-
> >  drivers/gpu/drm/i915/intel_bios.c     |   1 -
> >  drivers/gpu/drm/i915/intel_ddi.c      | 153 ++++++-----
> >  drivers/gpu/drm/i915/intel_display.c  |  44 +--
> >  drivers/gpu/drm/i915/intel_dpll_mgr.c |   3 +-
> >  drivers/gpu/drm/i915/intel_drv.h      |   8 +-
> >  drivers/gpu/drm/i915/intel_dsi.h      |   5 +
> >  drivers/gpu/drm/i915/intel_dsi_vbt.c  |  58 +++-
> >  drivers/gpu/drm/i915/intel_panel.c    |   3 +-
> >  10 files changed, 674 insertions(+), 105 deletions(-)
>
> --
> Jani Nikula, Intel Open Source Graphics Center