[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] dma-buf: add new dma_fence_chain container v4

Patchwork patchwork at emeril.freedesktop.org
Tue Dec 11 11:18:29 UTC 2018 

== Series Details ==

Series: series starting with [01/10] dma-buf: add new dma_fence_chain container v4
URL   : https://patchwork.freedesktop.org/series/53879/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
840d7cb7e1cc dma-buf: add new dma_fence_chain container v4
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno,

-:31: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

-:36: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#36: FILE: drivers/dma-buf/dma-fence-chain.c:1:
+/*

-:94: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#94: FILE: drivers/dma-buf/dma-fence-chain.c:59:
+	while ((prev = dma_fence_chain_get_prev(chain))) {
+

-:156: ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: drivers/dma-buf/dma-fence-chain.c:121:
+        return "dma_fence_chain";$

-:156: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: drivers/dma-buf/dma-fence-chain.c:121:
+        return "dma_fence_chain";$

-:161: ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: drivers/dma-buf/dma-fence-chain.c:126:
+        return "unbound";$

-:161: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: drivers/dma-buf/dma-fence-chain.c:126:
+        return "unbound";$

-:283: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#283: FILE: include/linux/dma-fence-chain.h:1:
+/*

-:318: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#318: FILE: include/linux/dma-fence-chain.h:36:
+	spinlock_t lock;

-:352: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#352: FILE: include/linux/dma-fence-chain.h:70:
+#define dma_fence_chain_for_each(iter, head)	\
+	for (iter = dma_fence_get(head); iter; \
+	     iter = dma_fence_chain_walk(head))

-:352: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'head' - possible side-effects?
#352: FILE: include/linux/dma-fence-chain.h:70:
+#define dma_fence_chain_for_each(iter, head)	\
+	for (iter = dma_fence_get(head); iter; \
+	     iter = dma_fence_chain_walk(head))

-:363: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 2 errors, 7 warnings, 4 checks, 328 lines checked
87065bf020ee drm/syncobj: remove drm_syncobj_cb and cleanup
-:77: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#77: FILE: drivers/gpu/drm/drm_syncobj.c:107:
+		wait->fence = dma_fence_get(

-:217: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 0 errors, 1 warnings, 1 checks, 186 lines checked
59a66b97c017 drm/syncobj: add new drm_syncobj_add_point interface v3
-:87: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 0 errors, 1 warnings, 0 checks, 60 lines checked
2b8a180d5fb2 drm/syncobj: add support for timeline point wait v8
-:11: WARNING:TYPO_SPELLING: 'seperate' may be misspelled - perhaps 'separate'?
#11: 
add seperate ioctl for timeline point wait, otherwise break uapi.

-:54: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#54: FILE: drivers/gpu/drm/drm_ioctl.c:679:
+		      DRM_UNLOCKED|DRM_RENDER_ALLOW),
 		                  ^

-:163: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!points"
#163: FILE: drivers/gpu/drm/drm_syncobj.c:680:
+	if (points == NULL)

-:324: CHECK:LINE_SPACING: Please don't use multiple blank lines
#324: FILE: drivers/gpu/drm/drm_syncobj.c:998:
+
+

-:356: CHECK:LINE_SPACING: Please don't use multiple blank lines
#356: FILE: include/uapi/drm/drm.h:763:
+
+

total: 0 errors, 1 warnings, 4 checks, 302 lines checked
baf631df82a6 drm/syncobj: add timeline payload query ioctl v4
-:44: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#44: FILE: drivers/gpu/drm/drm_ioctl.c:685:
+		      DRM_UNLOCKED|DRM_RENDER_ALLOW),
 		                  ^

-:114: CHECK:LINE_SPACING: Please don't use multiple blank lines
#114: FILE: include/uapi/drm/drm.h:777:
+
+

total: 0 errors, 0 warnings, 2 checks, 84 lines checked
910c349cf9d7 drm/syncobj: use the timeline point in drm_syncobj_find_fence v3
-:77: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken at gmail.com>'

total: 0 errors, 1 warnings, 0 checks, 56 lines checked
0311d860d79e drm/amdgpu: add timeline support in amdgpu CS v2
-:43: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#43: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu.h:467:
+	unsigned			num_post_deps;

-:121: CHECK:LINE_SPACING: Please don't use multiple blank lines
#121: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1146:
 
+

-:126: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#126: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1151:
+	unsigned num_deps;

-:168: CHECK:LINE_SPACING: Please don't use multiple blank lines
#168: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1187:
+
+

-:182: CHECK:LINE_SPACING: Please don't use multiple blank lines
#182: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1201:
+
+

-:188: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#188: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1207:
+	unsigned num_deps;

-:300: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: include/uapi/drm/amdgpu_drm.h:604:
+       __u32 handle;$

-:301: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: include/uapi/drm/amdgpu_drm.h:605:
+       __u32 flags;$

-:302: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: include/uapi/drm/amdgpu_drm.h:606:
+       __u64 point;$

total: 0 errors, 6 warnings, 3 checks, 266 lines checked
2dd3be4e6245 drm/syncobj: add transition iotcls between binary and timeline v2
-:35: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#35: FILE: drivers/gpu/drm/drm_ioctl.c:677:
+		      DRM_UNLOCKED|DRM_RENDER_ALLOW),
 		                  ^

-:56: WARNING:BRACES: braces {} are not necessary for single statement blocks
#56: FILE: drivers/gpu/drm/drm_syncobj.c:682:
+	if (!timeline_syncobj) {
+		return -ENOENT;
+	}

-:64: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*chain)...) over kzalloc(sizeof(struct dma_fence_chain)...)
#64: FILE: drivers/gpu/drm/drm_syncobj.c:690:
+	chain = kzalloc(sizeof(struct dma_fence_chain), GFP_KERNEL);

-:100: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#100: FILE: drivers/gpu/drm/drm_syncobj.c:726:
+}
+int

total: 0 errors, 1 warnings, 3 checks, 118 lines checked
0c1208ed2010 drm/syncobj: add timeline signal ioctl for syncobj v2
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6: 
v2: individually allocate chain array, since chain node is free independently.

-:32: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#32: FILE: drivers/gpu/drm/drm_ioctl.c:687:
+		      DRM_UNLOCKED|DRM_RENDER_ALLOW),
 		                  ^

-:85: CHECK:LINE_SPACING: Please don't use multiple blank lines
#85: FILE: drivers/gpu/drm/drm_syncobj.c:1217:
+
+

-:96: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*chains[i])...) over kzalloc(sizeof(struct dma_fence_chain)...)
#96: FILE: drivers/gpu/drm/drm_syncobj.c:1228:
+		chains[i] = kzalloc(sizeof(struct dma_fence_chain), GFP_KERNEL);

-:106: CHECK:BRACES: braces {} should be used on all arms of this statement
#106: FILE: drivers/gpu/drm/drm_syncobj.c:1238:
+		if (points[i]) {
[...]
+		} else
[...]

-:112: CHECK:BRACES: Unbalanced braces around else statement
#112: FILE: drivers/gpu/drm/drm_syncobj.c:1244:
+		} else

total: 0 errors, 1 warnings, 5 checks, 110 lines checked
b2b237d605c5 drm/amdgpu: update version for timeline syncobj support in amdgpu
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 11 lines checked

More information about the Intel-gfx mailing list