[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev3)

[Patchwork]

== Series Details ==

Series: Add HDR Metadata Parsing and handling in DRM layer (rev3)
URL   : https://patchwork.freedesktop.org/series/25091/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9feff89ee8cd drm: Add HDR source metadata property
9274c63b5377 drm: Add CEA extended tag blocks and HDR bitfield macros
c0f32ec43843 drm: Parse HDR metadata info from EDID
-:34: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#34: FILE: drivers/gpu/drm/drm_edid.c:3834:
+{
+

-:40: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#40: FILE: drivers/gpu/drm/drm_edid.c:3840:
+
+}

-:44: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#44: FILE: drivers/gpu/drm/drm_edid.c:3844:
+{
+

total: 0 errors, 0 warnings, 3 checks, 57 lines checked
c32feedce988 drm: Parse Colorimetry data block from EDID
-:43: CHECK:LINE_SPACING: Please don't use multiple blank lines
#43: FILE: drivers/gpu/drm/drm_edid.c:3842:
+
+

total: 0 errors, 0 warnings, 1 checks, 44 lines checked
8ba29ca0b12a drm/i915: Attach HDR metadata property to connector
-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2158:
+	drm_object_attach_property(&connector->base,
+		connector->dev->mode_config.hdr_source_metadata_property, 0);

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
26b04ef7c84c drm: Add HDR capability field to plane structure
-:26: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#26: FILE: include/drm/drm_plane.h:642:
+	bool hdr_supported;

total: 0 errors, 0 warnings, 1 checks, 9 lines checked
8595788ee7d3 drm: Implement HDR source metadata set and get property handling
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/drm_atomic.c:874:
+	drm_printf(p, "\thdr_metadata_changed=%d\n",
+					state->hdr_metadata_changed);

-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/drm_atomic_uapi.c:741:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+				&state->hdr_source_metadata_blob_ptr,

total: 0 errors, 0 warnings, 2 checks, 39 lines checked
69240a4dd2ec drm: Enable HDR infoframe support
-:54: CHECK:LINE_SPACING: Please don't use multiple blank lines
#54: FILE: drivers/gpu/drm/drm_edid.c:4946:
+
+

-:83: CHECK:LINE_SPACING: Please don't use multiple blank lines
#83: FILE: drivers/gpu/drm/drm_edid.c:4975:
+
+

-:215: ERROR:CODE_INDENT: code indent should use tabs where possible
#215: FILE: drivers/video/hdmi.c:1386:
+                                  struct device *dev,$

-:215: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#215: FILE: drivers/video/hdmi.c:1386:
+static void hdmi_drm_infoframe_log(const char *level,
+                                  struct device *dev,

-:215: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: drivers/video/hdmi.c:1386:
+                                  struct device *dev,$

-:216: ERROR:CODE_INDENT: code indent should use tabs where possible
#216: FILE: drivers/video/hdmi.c:1387:
+                                  struct hdmi_drm_infoframe *frame)$

-:216: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#216: FILE: drivers/video/hdmi.c:1387:
+                                  struct hdmi_drm_infoframe *frame)$

-:221: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#221: FILE: drivers/video/hdmi.c:1392:
+	hdmi_infoframe_log_header(level, dev,
+			(struct hdmi_any_infoframe *)frame);

-:234: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#234: FILE: drivers/video/hdmi.c:1405:
+	hdmi_log("max_mastering_display_luminance: %d\n",
+			frame->max_mastering_display_luminance);

-:236: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#236: FILE: drivers/video/hdmi.c:1407:
+	hdmi_log("min_mastering_display_luminance: %d\n",
+			frame->min_mastering_display_luminance);

total: 2 errors, 2 warnings, 6 checks, 279 lines checked
09c5cf8f9dc8 drm/i915: Write HDR infoframe and send to panel
4b5a7e4be9bf drm/i915: [DO NOT MERGE] hack for glk board outputs
2ca030434539 drm/i915: Add HLG EOTF
95b30187cd3b drm/i915: Enable infoframes on GLK+ for HDR
-:47: WARNING:LONG_LINE: line over 100 characters
#47: FILE: drivers/gpu/drm/i915/i915_reg.h:8058:
+#define GLK_TVIDEO_DIP_DRM_DATA(trans, i)	_MMIO_TRANS2(trans, _GLK_VIDEO_DIP_DRM_DATA_A + (i) * 4)

total: 0 errors, 1 warnings, 0 checks, 70 lines checked
885017e75a4b drm/i915:Enabled Modeset when HDR Infoframe changes
-:57: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#57: FILE: drivers/gpu/drm/i915/intel_hdmi.c:495:
+	if (!conn_state->hdr_source_metadata_blob_ptr ||
+		conn_state->hdr_source_metadata_blob_ptr->length == 0)

total: 0 errors, 0 warnings, 1 checks, 37 lines checked
def7680b600d drivers/video: Constantify function argument for HDMI infoframe log