[Intel-gfx] [PATCH] drm/amd: Compile fix for amdgpu_dm.c

kbuild test robot lkp at intel.com
Thu Dec 13 18:57:42 UTC 2018


Hi Mika,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20181213]
[cannot apply to v4.20-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mika-Kuoppala/drm-amd-Compile-fix-for-amdgpu_dm-c/20181213-062039
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_mode_config_init':
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1666:30: error: passing argument 1 of 'drm_atomic_private_obj_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
     drm_atomic_private_obj_init(adev->ddev,
                                 ^~~~
   In file included from include/drm/drm_dp_mst_helper.h:27:0,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57,
                    from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:31:
   include/drm/drm_atomic.h:403:6: note: expected 'struct drm_private_obj *' but argument is of type 'struct drm_device *'
    void drm_atomic_private_obj_init(struct drm_private_obj *obj,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1667:9: error: passing argument 2 of 'drm_atomic_private_obj_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
            &adev->dm.atomic_obj,
            ^
   In file included from include/drm/drm_dp_mst_helper.h:27:0,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57,
                    from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:31:
   include/drm/drm_atomic.h:403:6: note: expected 'struct drm_private_state *' but argument is of type 'struct drm_private_obj *'
    void drm_atomic_private_obj_init(struct drm_private_obj *obj,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1668:9: error: passing argument 3 of 'drm_atomic_private_obj_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
            &state->base,
            ^
   In file included from include/drm/drm_dp_mst_helper.h:27:0,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57,
                    from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:31:
   include/drm/drm_atomic.h:403:6: note: expected 'const struct drm_private_state_funcs *' but argument is of type 'struct drm_private_state *'
    void drm_atomic_private_obj_init(struct drm_private_obj *obj,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1666:2: error: too many arguments to function 'drm_atomic_private_obj_init'
     drm_atomic_private_obj_init(adev->ddev,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/drm/drm_dp_mst_helper.h:27:0,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h:46,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu.h:57,
                    from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:31:
   include/drm/drm_atomic.h:403:6: note: declared here
    void drm_atomic_private_obj_init(struct drm_private_obj *obj,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/drm_atomic_private_obj_init +1666 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c

  1631	
  1632	static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)
  1633	{
  1634		struct dm_atomic_state *state;
  1635		int r;
  1636	
  1637		adev->mode_info.mode_config_initialized = true;
  1638	
  1639		adev->ddev->mode_config.funcs = (void *)&amdgpu_dm_mode_funcs;
  1640		adev->ddev->mode_config.helper_private = &amdgpu_dm_mode_config_helperfuncs;
  1641	
  1642		adev->ddev->mode_config.max_width = 16384;
  1643		adev->ddev->mode_config.max_height = 16384;
  1644	
  1645		adev->ddev->mode_config.preferred_depth = 24;
  1646		adev->ddev->mode_config.prefer_shadow = 1;
  1647		/* indicates support for immediate flip */
  1648		adev->ddev->mode_config.async_page_flip = true;
  1649	
  1650		adev->ddev->mode_config.fb_base = adev->gmc.aper_base;
  1651	
  1652		drm_modeset_lock_init(&adev->dm.atomic_obj_lock);
  1653	
  1654		state = kzalloc(sizeof(*state), GFP_KERNEL);
  1655		if (!state)
  1656			return -ENOMEM;
  1657	
  1658		state->context = dc_create_state();
  1659		if (!state->context) {
  1660			kfree(state);
  1661			return -ENOMEM;
  1662		}
  1663	
  1664		dc_resource_state_copy_construct_current(adev->dm.dc, state->context);
  1665	
> 1666		drm_atomic_private_obj_init(adev->ddev,
  1667					    &adev->dm.atomic_obj,
  1668					    &state->base,
  1669					    &dm_atomic_state_funcs);
  1670	
  1671		r = amdgpu_display_modeset_create_props(adev);
  1672		if (r)
  1673			return r;
  1674	
  1675		return 0;
  1676	}
  1677	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 67839 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20181214/913ae521/attachment-0001.gz>


More information about the Intel-gfx mailing list