[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup

Fri Dec 14 01:38:20 UTC 2018

== Series Details ==

Series: MST refcounting/atomic helpers cleanup
URL   : https://patchwork.freedesktop.org/series/54030/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
69cf74524440 drm/dp_mst: Remove bogus conditional in drm_dp_update_payload_part1()
6b4005731a4b drm/dp_mst: Refactor drm_dp_update_payload_part1()
e2f94fce005b drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
-:22: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 91a25e463130 ("drm/dp/mst: deallocate payload on port destruction")'
#22: 
91a25e463130 ("drm/dp/mst: deallocate payload on port destruction")

-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")

-:27: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")'
#27: 
263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")

-:46: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c54c7374ff44 ("drm/dp_mst: Skip validating ports during destruction, just ref")'
#46: 
c54c7374ff44 ("drm/dp_mst: Skip validating ports during destruction, just ref")

-:51: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")'
#51: 
9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")

-:101: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#101: 
new file mode 100644

-:428: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#428: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:894:
+	DRM_DEBUG("mstb %p (%d)\n", mstb, kref_read(&mstb->malloc_kref)-1);
 	                                                               ^

-:471: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#471: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:937:
+	DRM_DEBUG("port %p (%d)\n", port, kref_read(&port->malloc_kref)-1);
 	                                                               ^

-:605: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#605: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1058:
+	DRM_DEBUG("mstb %p (%d)\n", mstb, kref_read(&mstb->topology_kref)-1);
 	                                                                 ^

-:714: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#714: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1181:
+	DRM_DEBUG("port %p (%d)\n", port, kref_read(&port->topology_kref)-1);
 	                                                                 ^

-:734: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#734: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1197:
+			rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:754: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#754: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1214:
+		rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:780: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#780: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1235:
+			mport = drm_dp_mst_topology_get_port_validated_locked(

-:800: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#800: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1252:
+		rport = drm_dp_mst_topology_get_port_validated_locked(

total: 4 errors, 2 warnings, 8 checks, 1258 lines checked
45508c149b9e drm/dp_mst: Stop releasing VCPI when removing ports from topology
bb69acc1a685 drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
-:92: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#92: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2155:
+				port = drm_dp_mst_topology_get_port_validated(

total: 0 errors, 0 warnings, 1 checks, 124 lines checked
f7fb04a02f7c drm/i915: Keep malloc references to MST ports
cf8a68c1efd5 drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
13984c5ea301 drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
106eea116ce9 drm/nouveau: Fix potential use-after-frees for MSTCs
47a8052bcd5e drm/nouveau: Stop unsetting mstc->port, use malloc refs
da2150a45314 drm/nouveau: Grab payload lock in nv50_msto_payload()
38ced18302b4 drm/dp_mst: Add some atomic state iterator macros
-:106: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#106: FILE: include/drm/drm_dp_mst_helper.h:697:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:106: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#106: FILE: include/drm/drm_dp_mst_helper.h:697:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:108: WARNING:LONG_LINE: line over 100 characters
#108: FILE: include/drm/drm_dp_mst_helper.h:699:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:123: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#123: FILE: include/drm/drm_dp_mst_helper.h:714:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:123: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#123: FILE: include/drm/drm_dp_mst_helper.h:714:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:125: WARNING:LONG_LINE: line over 100 characters
#125: FILE: include/drm/drm_dp_mst_helper.h:716:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#141: FILE: include/drm/drm_dp_mst_helper.h:732:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#141: FILE: include/drm/drm_dp_mst_helper.h:732:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:143: WARNING:LONG_LINE: line over 100 characters
#143: FILE: include/drm/drm_dp_mst_helper.h:734:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

total: 0 errors, 3 warnings, 6 checks, 120 lines checked
ccded9c0a4ba drm/dp_mst: Start tracking per-port VCPI allocations
6f6ba4dab707 drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
36339baac207 drm/nouveau: Use atomic VCPI helpers for MST