[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Fix TypeC legacy HPD handling (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Dec 14 19:17:58 UTC 2018


== Series Details ==

Series: drm/i915/icl: Fix TypeC legacy HPD handling (rev2)
URL   : https://patchwork.freedesktop.org/series/54017/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
39a8e2bef8b8 drm/i915/icl: Add a debug print for TypeC port disconnection
-:29: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#29: FILE: drivers/gpu/drm/i915/intel_dp.c:5071:
+	static const char *names[] = {

total: 0 errors, 1 warnings, 0 checks, 65 lines checked
4038ff7e5289 drm/i915/bios: Parse the VBT TypeC and Thunderbolt port flags
-:43: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#43: FILE: drivers/gpu/drm/i915/intel_bios.c:1389:
+	if (bdb_version >= 195)
+	       info->supports_typec_usb = child->dp_usb_type_c;

total: 0 errors, 1 warnings, 0 checks, 25 lines checked
073e19935f67 drm/i915/icl: Fix HPD handling for TypeC legacy ports
-:270: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield.  Prefer bool bitfields as unsigned int or u<8|16|32>
#270: FILE: drivers/gpu/drm/i915/intel_drv.h:1237:
+	bool tc_legacy_port:1;

total: 0 errors, 1 warnings, 0 checks, 188 lines checked
4b9db3b474f7 drm/i915/icl: Add fallback detection method for TypeC legacy ports



More information about the Intel-gfx mailing list