[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for sysfs: Disable lockdep for driver bind/unbind files (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed Dec 19 13:07:54 UTC 2018


== Series Details ==

Series: sysfs: Disable lockdep for driver bind/unbind files (rev2)
URL   : https://patchwork.freedesktop.org/series/54238/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
edb688c07371 sysfs: Disable lockdep for driver bind/unbind files
-:106: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 356c05d58af0 ("sysfs: get rid of some lockdep false positives")'
#106: 
commit 356c05d58af05d582e634b54b40050c73609617b

-:112: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e9b526fe7048 ("i2c: suppress lockdep warning on delete_device")'
#112: 
commit e9b526fe704812364bca07edd15eadeba163ebfb

-:153: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
#153: FILE: drivers/base/bus.c:201:
+static DRIVER_ATTR_IGNORE_LOCKDEP(unbind, S_IWUSR, NULL, unbind_store);

-:162: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
#162: FILE: drivers/base/bus.c:237:
+static DRIVER_ATTR_IGNORE_LOCKDEP(bind, S_IWUSR, NULL, bind_store);

-:174: CHECK:LINE_SPACING: Please don't use multiple blank lines
#174: FILE: include/linux/device.h:330:
 
+

-:177: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 2 errors, 3 warnings, 1 checks, 32 lines checked



More information about the Intel-gfx mailing list