[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: add OA interrupt support

[Patchwork]

== Series Details ==

Series: drm/i915/perf: add OA interrupt support
URL   : https://patchwork.freedesktop.org/series/54280/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2834454cd419 drm/i915/perf: rework aging tail workaround
-:197: CHECK:SPACING: No space is necessary after a cast
#197: FILE: drivers/gpu/drm/i915/i915_perf.c:510:
+			u32 *report32 = (void *) report;

-:273: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#273: FILE: drivers/gpu/drm/i915/i915_perf.c:811:
+		report32[0] = report32[1] = 0;

-:308: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#308: FILE: drivers/gpu/drm/i915/i915_perf.c:1020:
+		report32[0] = report32[1] = 0;

total: 0 errors, 0 warnings, 3 checks, 302 lines checked
f1333882b447 drm/i915/perf: add new open param to configure polling of OA buffer
fe9e65a1f4ce drm/i915/perf: handle interrupts from the OA unit
-:28: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#28: FILE: drivers/gpu/drm/i915/i915_drv.h:1362:
+	bool oa_interrupt_monitor;

total: 0 errors, 0 warnings, 1 checks, 250 lines checked
a117d9888415 drm/i915/perf: add interrupt enabling parameter
-:7: WARNING:TYPO_SPELLING: 'conjuction' may be misspelled - perhaps 'conjunction'?
#7: 
mechanism of the HW. In conjuction with long periods for checks for

-:30: CHECK:LINE_SPACING: Please don't use multiple blank lines
#30: FILE: drivers/gpu/drm/i915/i915_perf.c:431:
 
+

-:80: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_priv->perf.oa.half_full_count_last !=
 	     atomic64_read(&dev_priv->perf.oa.half_full_count)'
#80: FILE: drivers/gpu/drm/i915/i915_perf.c:685:
+	if (stream->oa_interrupt_monitor &&
+	    (dev_priv->perf.oa.half_full_count_last !=
+	     atomic64_read(&dev_priv->perf.oa.half_full_count))) {

-:97: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_priv->perf.oa.half_full_count_last !=
 	     atomic64_read(&dev_priv->perf.oa.half_full_count)'
#97: FILE: drivers/gpu/drm/i915/i915_perf.c:978:
+	if (stream->oa_interrupt_monitor &&
+	    (dev_priv->perf.oa.half_full_count_last !=
+	     atomic64_read(&dev_priv->perf.oa.half_full_count))) {

-:143: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_priv->perf.oa.half_full_count_last !=
 	     atomic64_read(&dev_priv->perf.oa.half_full_count)'
#143: FILE: drivers/gpu/drm/i915/i915_perf.c:2370:
+	if (stream->oa_interrupt_monitor &&
+	    (dev_priv->perf.oa.half_full_count_last !=
+	     atomic64_read(&dev_priv->perf.oa.half_full_count))) {

-:172: WARNING:TYPO_SPELLING: 'conjuction' may be misspelled - perhaps 'conjunction'?
#172: FILE: include/uapi/drm/i915_drm.h:1552:
+	 * buffer in i915. This option in conjuction with a long polling delay

total: 0 errors, 2 warnings, 4 checks, 147 lines checked