[Intel-gfx] [PATCH v9 13/39] drm: HDCP2.2 link check related constants

[Daniel Vetter]

On Wed, Dec 19, 2018 at 5:22 PM C, Ramalingam <ramalingam.c at intel.com> wrote:
>
>
> On 12/19/2018 9:28 PM, Daniel Vetter wrote:
> > On Wed, Dec 19, 2018 at 09:09:00PM +0530, C, Ramalingam wrote:
> >> On 12/19/2018 8:46 PM, Daniel Vetter wrote:
> >>> On Thu, Dec 13, 2018 at 09:31:15AM +0530, Ramalingam C wrote:
> >>>> Enums and macros are defined for HDCP2.2 link check.
> >>>>
> >>>> Signed-off-by: Ramalingam C <ramalingam.c at intel.com>
> >>>> ---
> >>>>    include/drm/drm_hdcp.h | 8 ++++++++
> >>>>    1 file changed, 8 insertions(+)
> >>>>
> >>>> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> >>>> index d8093ecf3ddc..21a128e7020a 100644
> >>>> --- a/include/drm/drm_hdcp.h
> >>>> +++ b/include/drm/drm_hdcp.h
> >>>> @@ -11,6 +11,14 @@
> >>>>    /* Period of hdcp checks (to ensure we're still authenticated) */
> >>>>    #define DRM_HDCP_CHECK_PERIOD_MS                (128 * 16)
> >>>> +#define DRM_HDCP2_CHECK_PERIOD_MS         500
> >>> This one here is good imo, and has my Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> >>>
> >>>> +
> >>>> +enum check_link_response {
> >>>> +  DRM_HDCP_LINK_PROTECTED = 0,
> >>>> +  DRM_HDCP_TOPOLOGY_CHANGE,
> >>>> +  DRM_HDCP_LINK_INTEGRITY_FAILURE,
> >>>> +  DRM_HDCP_REAUTH_REQUEST
> >>>> +};
> >>> But this one here is just a part of the intel_hdcp_shim interface. I think
> >>> we should put into the intel_drv.h header, and change the return value of
> >>> the check_2_2_link hook to this enum. I think that would clarify the code
> >>> a lot. Plus then ofc merge this part into the first patch that uses it.
> >> daniel,
> >>
> >> this is generic link check results as per the HDCP spec. This could be used
> >> by any other driver in DRM. Still should i move as local to intel?
> > Yeah I think makes more sense. intel_hdcp_shim could also be used as
> > fairly generic hdcp implementation, but right now it isn't. Better to keep
> > things together that are used together.
>
> thanks. With this i will use your R-b ?

Just to clarify: R-b with the enum moved to intel_drv.h, together with
the intel_hdcp_shim using it. Just realized that my reply is a bit
confusing.
-Daniel

>
> -Ram
>
> > -Daniel
> >
> >> -Ram
> >>
> >>> With that remaining patches have my ack, too.
> >>>
> >>> Cheers, Daniel
> >>>
> >>>>    /* Shared lengths/masks between HDMI/DVI/DisplayPort */
> >>>>    #define DRM_HDCP_AN_LEN                         8
> >>>> --
> >>>> 2.7.4
> >>>>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch