[Intel-gfx] [PATCH] drm/i915/dsc: Fix the deadlock in dsc debugfs node

Lyude Paul lyude at redhat.com
Wed Dec 19 23:50:58 UTC 2018


Reviewed-by: Lyude Paul <lyude at redhat.com>

On Wed, 2018-12-19 at 15:51 -0800, Manasi Navare wrote:
> The DSC debugfs node causes a possible deadlock situation. This patch
> resets the try_again at the beginning of loop to fix this.
> 
> Fixes: e845f099f1c6 ('drm/i915/dsc: Add Per connector debugfs node for DSC
> support/enable')
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109097
> Cc: Lyude Paul <lyude at redhat.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Manasi Navare <manasi.d.navare at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 77486a614614..aca26a25ed50 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -5108,6 +5108,7 @@ static int i915_dsc_fec_support_show(struct seq_file
> *m, void *data)
>  	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
>  
>  	do {
> +		try_again = false;
>  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
>  				       &ctx);
>  		if (ret) {
-- 
Cheers,
	Lyude Paul



More information about the Intel-gfx mailing list