[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2)

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 20 13:45:38 UTC 2018


== Series Details ==

Series: series starting with [v2,1/3] drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2)
URL   : https://patchwork.freedesktop.org/series/54339/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
79612d0a1354 drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2)
-:71: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name
#71: FILE: drivers/gpu/drm/i915/intel_drv.h:246:
+	void (*update_pipe)(struct intel_encoder *,

-:71: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct intel_crtc_state *' should also have an identifier name
#71: FILE: drivers/gpu/drm/i915/intel_drv.h:246:
+	void (*update_pipe)(struct intel_encoder *,

-:71: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_connector_state *' should also have an identifier name
#71: FILE: drivers/gpu/drm/i915/intel_drv.h:246:
+	void (*update_pipe)(struct intel_encoder *,

total: 0 errors, 3 warnings, 0 checks, 44 lines checked
8b9d52c1738e drm/i915: Allow calling intel_edp_drrs_enable twice
d15d2e96832a drm/i915: DDI: call intel_psr_ and _edp_drrs_enable() on pipe updates (v2)
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14: 
-Merge the patches adding the intel_psr_enable() and intel_edp_drrs_enable()

total: 0 errors, 1 warnings, 0 checks, 31 lines checked



More information about the Intel-gfx mailing list