[Intel-gfx] [PATCH] drm/i915: Unwind failure on pinning the gen7 ppgtt

Matthew Auld matthew.william.auld at gmail.com
Sat Dec 22 11:09:02 UTC 2018


On Sat, 22 Dec 2018 at 03:06, Chris Wilson <chris at chris-wilson.co.uk> wrote:
>
> If we fail to pin the ggtt vma slot for the ppgtt page tables, we need
> to unwind the locals before reporting the error. Or else on subsequent
> attempts to bind the page tables into the ggtt, we will already believe
> that the vma has been pinned and continue on blithely. If something else
> should happen to be at that location, choas ensues.
>
> Fixes: a2bbf7148342 ("drm/i915/gtt: Only keep gen6 page directories pinned while active")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Cc: Matthew Auld <matthew.william.auld at gmail.com>
> Cc: <stable at vger.kernel.org> # v4.19+
Reviewed-by: Matthew Auld <matthew.william.auld at gmail.com>


More information about the Intel-gfx mailing list