[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: modparam rework prep work

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 27 14:59:33 UTC 2018


== Series Details ==

Series: drm/i915: modparam rework prep work
URL   : https://patchwork.freedesktop.org/series/54499/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ef92c4788911 drm/i915: add a helper to make a copy of i915_params
-:53: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#53: FILE: drivers/gpu/drm/i915/i915_params.c:216:
+#define DUP(T, x, ...) dup_param(#T, &dest->x);

-:53: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#53: FILE: drivers/gpu/drm/i915/i915_params.c:216:
+#define DUP(T, x, ...) dup_param(#T, &dest->x);

total: 0 errors, 1 warnings, 1 checks, 43 lines checked
446aa1f787ee drm/i915: add a helper to free the members of i915_params
-:54: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#54: FILE: drivers/gpu/drm/i915/i915_params.c:232:
+#define FREE(T, x, ...) free_param(#T, &params->x);

-:54: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#54: FILE: drivers/gpu/drm/i915/i915_params.c:232:
+#define FREE(T, x, ...) free_param(#T, &params->x);

total: 0 errors, 1 warnings, 1 checks, 44 lines checked
1116230810cd drm/i915/uc: add dev_priv parameter to intel_uc_is_using_* functions
e41b8248dea6 drm/i915/params: set i915.enable_hangcheck permissions to 0600
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#26: FILE: drivers/gpu/drm/i915/i915_params.c:81:
+i915_param_named_unsafe(enable_hangcheck, bool, 0600,
 	"Periodically check GPU activity for detecting hangs. "

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
f21e97b58b40 drm/i915: move load failure injection to selftests
cef50b357096 drm/i915/params: document I915_PARAMS_FOR_EACH()



More information about the Intel-gfx mailing list