[Intel-gfx] [PATCH 1/6] drm: include drm_device.h from drm_legacy.h

[Daniel Vetter]

On Thu, Dec 27, 2018 at 05:04:20PM +0100, Daniel Vetter wrote:
> On Thu, Dec 27, 2018 at 02:56:36PM +0200, Jani Nikula wrote:
> > Make it easier to drop drmP.h includes.
> > 
> > Cc: Sam Ravnborg <sam at ravnborg.org>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> > ---
> >  include/drm/drm_legacy.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/drm/drm_legacy.h b/include/drm/drm_legacy.h
> > index 8fad66f88e4f..743d7e70c896 100644
> > --- a/include/drm/drm_legacy.h
> > +++ b/include/drm/drm_legacy.h
> > @@ -2,6 +2,7 @@
> >  #define __DRM_DRM_LEGACY_H__
> >  
> >  #include <drm/drm_auth.h>
> > +#include <drm/drm_device.h>
> 
> From a quick look, shouldn't a
> 
> struct drm_device;
> 
> forward decl be enough? You might need a pile more forward decl, but
> that's all drm_device.h seems to pull in that drm_legacy.h needs.

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> with the forward decl
(assuming it all works out).
-Daniel

> -Daniel
> >  
> >  /*
> >   * Legacy driver interfaces for the Direct Rendering Manager
> > -- 
> > 2.11.0
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch