[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Implement Selective Write workaround for Haswell GT1

Patchwork patchwork at emeril.freedesktop.org
Fri Dec 28 12:52:26 UTC 2018


== Series Details ==

Series: series starting with [1/3] drm/i915: Implement Selective Write workaround for Haswell GT1
URL   : https://patchwork.freedesktop.org/series/54518/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
31de8b9fbab2 drm/i915: Implement Selective Write workaround for Haswell GT1
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
The docs specify this needs to be set on HSW GT1 parts. I've implemented it as

-:19: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 2c550183476d ("drm/i915: Disable PSMI sleep messages on all rings around context switches")'
#19: 
commit 2c550183476dfa25641309ae9a28d30feed14379

-:28: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 2c550183476d ("drm/i915: Disable PSMI sleep messages on all rings around context switches")'
#28: 
References: 2c550183476d ("drm/i915: Disable PSMI sleep messages on all rings around context switches")

-:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#41: FILE: drivers/gpu/drm/i915/i915_drv.h:2279:
+#define IS_HSW_GT1(dev_priv)	(IS_HASWELL(dev_priv) && \
+				 (dev_priv)->info.gt == 1)

total: 2 errors, 1 warnings, 1 checks, 120 lines checked
a5d8fa604cef drm/i915: Remove HW semaphores for gen7 inter-engine synchronisation
777c7b9756eb drm/i915: Drop debugfs/i915_next_seqno



More information about the Intel-gfx mailing list