[Intel-gfx] [PATCH 3/6] drm: include idr.h from drm_file.h

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Dec 30 19:03:15 UTC 2018


Hi Jani,

Thank you for the patch.

On Thursday, 27 December 2018 14:56:38 EET Jani Nikula wrote:
> Make it easier to drop drmP.h includes.

How about explaining why idr.h is needed ?

"drm_file.h embeds idr structures in DRM-specific structures. Include the 
corresponding header to make drm_file.h self-contained."

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>  include/drm/drm_file.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
> index 84ac79219e4c..6710b612e2f6 100644
> --- a/include/drm/drm_file.h
> +++ b/include/drm/drm_file.h
> @@ -32,6 +32,7 @@
> 
>  #include <linux/types.h>
>  #include <linux/completion.h>
> +#include <linux/idr.h>
> 
>  #include <uapi/drm/drm.h>

-- 
Regards,

Laurent Pinchart





More information about the Intel-gfx mailing list